Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar image url, add ability to continue to get last activity image url #8

Merged
merged 3 commits into from Dec 14, 2018

Conversation

nhorvath
Copy link
Contributor

I was able to fix the avatar url (thanks @thoukydides) and restore that to the device.image property.
I exposed the last activity image url via device.activity_image.

I'm working on a HA change to add a config to skybell camera to support including the image of your choosing (or both). The default will be avatar image like it used to be.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7fb3cf4 on nhorvath:master into 19bc8ca on MisterWil:master.

@nhorvath
Copy link
Contributor Author

@MisterWil as soon as you publish the new version I can submit the PR to home assistant. I got it working with my local build but I'd rather keep it on yours.

New config is going to look something like this pending HA code review:

camera:
  - platform: skybell
    monitored_conditions:
    - avatar
    - activity
    activity_name: "Last Activity"
    avatar_name: ""

All new things are optional, names are optional and if set will be appended to device name. The default is just to monitor the avatar url.

@MisterWil MisterWil merged commit 4096831 into MisterWil:master Dec 14, 2018
@MisterWil
Copy link
Owner

Awesome! I saw that @thoukydides mentioned the avatar endpoint so I'm glad you quickly fixed that and kept the last activity one as well. Thank you so much!

Released 0.3.0 with this PR. :-)

@GaryOkie
Copy link

This is indeed great news! Love the options to have it both ways. Just one question - why is the default monitored conditioned named "avatar"?

I realize that name was in the path of the underlying Skybell URL that fetches the image, but shouldn't the configuration option be named something that better represents the most recent live/captured image?

@nhorvath
Copy link
Contributor Author

@GaryOkie mostly because that's what skybell calls it, but it's not a bad name. It's an avatar in that it's a digital representation of the camera. The updated homeassistant documentation explains what the options are, so I don't see this being a big deal.

@GaryOkie
Copy link

Thanks Nick - certainly not a big deal. Indeed, my avatar appears to be laughing at me not understanding what an avatar is. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants