Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linaria-3): Add support for linaria@3, update readme and bump version to 1.0.0 #3

Merged
merged 2 commits into from Jun 23, 2021
Merged

feat(linaria-3): Add support for linaria@3, update readme and bump version to 1.0.0 #3

merged 2 commits into from Jun 23, 2021

Conversation

timurrustamov
Copy link

Addressing the following issue - adding the support for linaria@3.

@mikestopcontinues
Copy link

This PR needs an extra bit of finessing to account for global styles. See this comment for working code.

@frnk94
Copy link

frnk94 commented Mar 10, 2021

This PR needs an extra bit of finessing to account for global styles. See this comment for working code.

Heads up this implementation still need fine tuning as it would prevent people from using pageExtensions feature from NextJs. The test Regex would need to take into account this feature.

@turadg turadg mentioned this pull request Mar 23, 2021
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 26, 2021
update with-linaria example (#23332)
4e5a359 
## Documentation / Examples

* removes deprecated `@zeit/next-css`.
* adds https://github.com/Mistereo/next-linaria to work with the new built-in CSS functionality.
* updates Linaria to latest release (v3 will require Mistereo/next-linaria#3 ) 
* adds an example of using Linaria without React
* gitignores `.linaria-cache`
@codingwithchris
Copy link

Hey there! Just wanted to check in and see what the status on this PR is? Would love to be able to link to version 1.0.0 directly instead of maintaining a linked copied/pasted version of the package :)

SokratisVidros pushed a commit to SokratisVidros/next.js that referenced this pull request Apr 20, 2021
@SokratisVidros
update with-linaria example (vercel#23332)
a1aa56a 
## Documentation / Examples

* removes deprecated `@zeit/next-css`.
* adds https://github.com/Mistereo/next-linaria to work with the new built-in CSS functionality.
* updates Linaria to latest release (v3 will require Mistereo/next-linaria#3 ) 
* adds an example of using Linaria without React
* gitignores `.linaria-cache`
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Apr 29, 2021
update with-linaria example (vercel#23332)
b8a889d 
## Documentation / Examples

* removes deprecated `@zeit/next-css`.
* adds https://github.com/Mistereo/next-linaria to work with the new built-in CSS functionality.
* updates Linaria to latest release (v3 will require Mistereo/next-linaria#3 ) 
* adds an example of using Linaria without React
* gitignores `.linaria-cache`
@Mistereo Mistereo merged commit 0bf2f15 into Mistereo:master Jun 23, 2021
@Mistereo
Copy link
Owner

Thank you for your PR and sorry for such a long delay.
Since linaria@3 is still in beta I published this as next-linaria@1.0.0-beta, it also includes changes from #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timurrustamov @mikestopcontinues @frnk94 @codingwithchris @Mistereo