Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CVar mapm_early_finish_vote #25

Merged
merged 6 commits into from Feb 6, 2022

Conversation

Nord1cWarr1or
Copy link
Contributor

Add CVar mapm_early_finish_vote which allows to finish voting early if all players have voted.

which allows to finish voting early if all players have voted.
Copy link
Owner

@Mistrick Mistrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не учитывает работу аддона GUI. Если он отключает вывод меню голосования, то условие никогда не проверится.

@Nord1cWarr1or
Copy link
Contributor Author

Не учитывает работу аддона GUI. Если он отключает вывод меню голосования, то условие никогда не проверится.

Согласен, не стал рассматривать его, поскольку его даже нет в закомментированном виде в plugins.ini.
Окей, попробую подружить квар с ним.

Copy link
Owner

@Mistrick Mistrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Версию плагина нужно изменить

@@ -89,6 +90,8 @@ new g_sPrefix[48];

new g_sDisplayedItemName[MAX_VOTELIST_SIZE + 1][MAPNAME_LENGTH * 2];

new g_playersnum;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g_iPlayersNum


if(get_num(EARLY_FINISH_VOTE) && g_iTotalVotes == g_playersnum) {
g_iTimer = 0;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно убрать пустую строку

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вкусовщина :D
ну окей

@@ -43,6 +43,7 @@ MAPM_WINS = wins
MAPM_VOTE_IN_NEXTROUND = Wait vote in next round.
MAPM_SECOND_VOTE = Second vote.
MAPM_CHANGELEVEL_NEXTROUND = Map will change in next round.
MAPM_EARLY_FINISH_VOTE = All players have voted, so we are ending voting^3 early.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точка в конце должна быть обычного цвета

@Nord1cWarr1or
Copy link
Contributor Author

@Mistrick done.

@Mistrick Mistrick merged commit 4059ca8 into Mistrick:master Feb 6, 2022
@Nord1cWarr1or Nord1cWarr1or deleted the early-finish-vote branch February 6, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants