Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures #573

Closed
jgarte opened this issue Nov 19, 2021 · 2 comments
Closed

Test failures #573

jgarte opened this issue Nov 19, 2021 · 2 comments

Comments

@jgarte
Copy link
Contributor

jgarte commented Nov 19, 2021

Do you happen to know what might cause these?

failures:
    external_editor::tests::activate_write_file_fail
    process::tests::error_write_todo
    tests::error_process

Some more context.

@MitMaro
Copy link
Owner

MitMaro commented Nov 19, 2021

I hate those particular tests because they are too fragile. I've been working to replace them with something a little more stable.

My guess, those tests depend on setting a file to be read only. If the OS/file system you are using doesn't support setting a file to read only, those tests will fail.

I also noticed in the test run you linked that external_editor::tests::activate_write_file_fail also failed, which requires writing a file. A small guess, is that the test/fixtures/ directory doesn't have write permissions enabled for the user running the tests in GitHub actions.

@MitMaro
Copy link
Owner

MitMaro commented Nov 27, 2021

Hey @jgarte , I'm going to close this issue, but if you have any other problems/questions feel free to comment/reopen.

@MitMaro MitMaro closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants