Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: git-interactive-rebase-tool-2.1.0. #34137

Closed
wants to merge 1 commit into from

Conversation

jgarte
Copy link
Contributor

@jgarte jgarte commented Nov 18, 2021

Home page: https://gitrebasetool.mitmaro.ca/

General

[x] This is a new package and it conforms to the quality requirements

Have the results of the proposed changes been tested?

[x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me

Does it build and run successfully?

[x] I built this PR locally for my native architecture, (x86_64)

@jgarte
Copy link
Contributor Author

jgarte commented Nov 18, 2021

Hi, I opened a new pr because I lost the old tree I was working on when I originally submitted this with #32013 and wasn't sure how to integrate it into the old PR via the github web UI.

This currently builds successfully for me and I tested it. I'm using the package on a daily basis.

@jgarte jgarte force-pushed the interactive-rebase-tool branch 7 times, most recently from ad62a88 to 6a2810e Compare November 18, 2021 22:21
@jgarte jgarte force-pushed the interactive-rebase-tool branch 2 times, most recently from 40b15d8 to c9246c7 Compare November 19, 2021 02:19
@paper42 paper42 added the new-package This PR adds a new package label Nov 19, 2021
@jgarte
Copy link
Contributor Author

jgarte commented Nov 19, 2021

Here's an explanation for why those particular 3 tests might be failing:

MitMaro/git-interactive-rebase-tool#573

I'll look into how to set that directory as read only.

@ericonr
Copy link
Member

ericonr commented Nov 21, 2021

Our CI runs as root, which might break those tests.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 22, 2021

Our CI runs as root, which might break those tests.

@ericonr Do you suggest I disable those three tests then?

@ericonr
Copy link
Member

ericonr commented Nov 22, 2021

If possible, yes.

@jgarte
Copy link
Contributor Author

jgarte commented Nov 22, 2021

If possible, yes.

@ericonr

I skipped those three tests in the template. Everything is green now :)

@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Jun 14, 2022
@github-actions github-actions bot closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants