Fix sharing of ThreadStatus #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application was creating two instances of Runtime, the first instance was only being used to create a ThreadStatus that was passed to Process. The second instance was the real Runtime, that would handle all the thread management and status tracking. The problem, was that Process had an incorrect copy of ThreadStatus, so the status checks Process performed were not completing. This resulted in things like the External Editor functionality stalling, when it was waiting for thread status updated. This change creates a single instance of the ThreadStatus that is shared across the Process and Runtime.
Pull Request Test Coverage Report for Build 5592038523
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application was creating two instances of Runtime, the first instance was only being used to create a ThreadStatus that was passed to Process. The second instance was the real Runtime, that would handle all the thread management and status tracking. The problem, was that Process had an incorrect copy of ThreadStatus, so the status checks Process performed were not completing. This resulted in things like the External Editor functionality stalling, when it was waiting for thread status updated.
This change creates a single instance of the ThreadStatus that is shared across the Process and Runtime.