Add Operation::Load to History #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitMaro
commented
Jul 21, 2023
| self.history.undo(&mut self.lines) | ||
| if let Some((operation, start, end)) = self.history.undo(&mut self.lines) { | ||
| return if operation == Operation::Load { | ||
| None |
Pull Request Test Coverage Report for Build 5726345979
💛 - Coveralls |
Add to the todo_file History a load operation tracker, that will acts as a sentinel value for the start of the undo history queue. This will enable hooking into the start of the history queue. In order to expose the additional information, the Operation is now returned from the History undo/redo methods.
MitMaro
force-pushed
the
mitmaro/add-operation-result-from-list-history
branch
from
1b2e6cb
to
4c593d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the todo_file History a load operation tracker, that will acts as a sentinel value for the start of the undo history queue. This will enable hooking into the start of the history queue. In order to expose the additional information, the Operation is now returned from the History undo/redo methods.