Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Accurately Calculate Which Tags Are Popular #41

Merged
merged 2 commits into from
Jun 17, 2013

Conversation

MitchellMcKenna
Copy link
Owner

  • When requesting tags, only those of a published posts will be
    returned.
  • tag_model get_all_tags() will calculate the number of items tagged
    dynatmically.
  • The column count of the tags table is unnecessary, the column and
    related code will be removed when the database migration tool is
    built.

Refs #38

- When requesting tags, only those of a published posts will be
  returned.
- tag_model get_all_tags() will calculate the number of items tagged
  dynatmically.
- The column count of the tags table is unnecessary, the column and
  related code will be removed when the database migration tool is
  built.

Refs #38
@therourke
Copy link

OK. I took the jump and added this new code. The tag cloud appears to be different, better. Great stuff. Anyway to have more items show in this by the way?

What hasn't changed though is the tag count in relation to the pages generated for each tag. So, if I go to the 'art' tag, my stream still thinks there are 800 items, rather than 80, so it generates enough page links at the bottom of the stream for 800 items. Pressing on page number '16' therefore leads to a page with nothing in it. You can see the page I mean here, scroll to the bottom and try out the generated page links: http://machinemachine.net/stream/items/tag/art

Does this make sense? Thanks

- If tags were deleted but somehow the relationship still existed the
  left join would have counted those ones as well.

Refs #41
MitchellMcKenna added a commit that referenced this pull request Jun 17, 2013
…-popularity

More Accurately Calculate Which Tags Are Popular
@MitchellMcKenna MitchellMcKenna merged commit 3f6cd29 into develop Jun 17, 2013
@MitchellMcKenna
Copy link
Owner Author

@therourke I was unable to reproduce your tag pagination issue, but I pushed up a potential fix, please checkout the develop branch and if your still seeing the issue please open a different issue for it so I can help debug it with you. I've also created issue #47 to add an option to the admin section for how many popular tags show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants