Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/dupe #425

Closed
IIUlqII opened this issue Feb 22, 2014 · 4 comments
Closed

bug/dupe #425

IIUlqII opened this issue Feb 22, 2014 · 4 comments

Comments

@IIUlqII
Copy link

IIUlqII commented Feb 22, 2014

1)place jabba barrel and bind item to it (example 1 diamond)
2)bind magic broom to this jabba barrel
3)give to broom any item and broom transform and place this item in barrel(example 3 dirt)
4)done(in barrel 4diamond)

@LazerusKI
Copy link

just tried that with Factorisation Barrels and Resonant Induction Crates - none of them has this problem, so its not related to the broom, instead its a problem with jabba barrels i think

@ProfMobius
Copy link

Looks like this problem is bouncing back to us for some reason.
The broom doesn't respect the ISidedInterface and try to put stuff in every slots it can find.

There is an easy test. Just grab a furnace, put stacks of stone in both the up and down slot and attach the broom to it. Anything will go to the output slot.

The ISidedInterface exists for a good reason, like having slots where external agents shouldn't be able to place stacks.

@taelnia
Copy link

taelnia commented Mar 21, 2014

Hi there. This does appear to be an issue with the broom. This behaviour(not the dupe, but the underlying issue) is also noticeable on vanilla furnaces.

Test case:

  • Place a furnace and put a full stack in the two input slots(for a simple test, just place a stack of stone in the fuel and top input slots).
  • Bind a magic broom to the furnace
  • throw some items on the ground
  • The items are going into the output slot of the furnace.

Jabba is not expecting items to be put into it's output slot. My guess would be that the broom is calling setInventorySlotContents on the (empty/matching item type) output slot without checking isItemValidForSlot or the ISidedInventory canInsertItem before the set.

@Mithion
Copy link
Owner

Mithion commented Jun 5, 2014

The broom has been updated to respect ISidedInventory in 1.2. I tell you, kids these days have no respect.
It is very sorry.

@Mithion Mithion closed this as completed Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants