Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from co to async/await #78

Closed
bdchauvette opened this issue Nov 1, 2017 · 0 comments · Fixed by #84
Closed

Switch from co to async/await #78

bdchauvette opened this issue Nov 1, 2017 · 0 comments · Fixed by #84

Comments

@bdchauvette
Copy link
Contributor

This would be a breaking change and would only work on node >=8, but it would remove the dependency on co and I think make the code slightly more idiomatic for vanilla JS.
bdchauvette added a commit to bdchauvette/mithril-node-render that referenced this issue Nov 1, 2017
@bdchauvette
Switch from co to async/await - fixes MithrilJS#78
bbbd3b8
StephanHoyer pushed a commit that referenced this issue Feb 12, 2018
@bdchauvette @StephanHoyer
Switch from co to async/await - fixes #78 (#81)
200963b 
* Switch from `co` to `async`/`await` - fixes #78

* Update node versions in Travis

Switching to `async`/`await` means that the library will no longer work (without transpiling) on any Node.js version <8.
StephanHoyer pushed a commit that referenced this issue Feb 12, 2018
@bdchauvette @StephanHoyer
Switch from co to async/await - fixes #78 (#81)
cde0e03 
* Switch from `co` to `async`/`await` - fixes #78

* Update node versions in Travis

Switching to `async`/`await` means that the library will no longer work (without transpiling) on any Node.js version <8.
@StephanHoyer StephanHoyer mentioned this issue Feb 12, 2018
Merged
StephanHoyer added a commit that referenced this issue Feb 12, 2018
@StephanHoyer
Switch from co to async/await - fixes #78 (#81) (#84)
c71dbae 
* Switch from `co` to `async`/`await` - fixes #78

* Update node versions in Travis

Switching to `async`/`await` means that the library will no longer work (without transpiling) on any Node.js version <8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from co to async/await - fixes #78 (#81) MithrilJS/mithril-node-render
1 participant
@bdchauvette