New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1921 #1922

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
3 participants
@pygy
Copy link
Member

pygy commented Jul 31, 2017

Description

fix for #1921: Don't visit the children array of components, even when the instance is null.

How Has This Been Tested?

npm run test before and after the fix. Fails before (exception thrown because the _state is null), succeeds after.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@pygy pygy requested a review from lhorie as a code owner Jul 31, 2017

@pygy pygy requested a review from tivac as a code owner Jul 31, 2017

@pygy pygy changed the title Add tests for issue 1921 (onremove fires on childrent that don't end up in the instance) Fix #1921 Jul 31, 2017

@isiahmeadows
Copy link
Collaborator

isiahmeadows left a comment

LGTM. An added bonus is that it's a little more readable, too. 😄 👍

@pygy pygy merged commit 157fb7d into MithrilJS:next Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pygy pygy deleted the pygy:fix-1921 branch Jul 31, 2017

@pygy

This comment has been minimized.

Copy link
Member

pygy commented Jul 31, 2017

Thanks @isiahmeadows I was about to add you as a reviewer (the others were added automatically)

@tivac while I don't feel like I "own" any file in the project, I wouldn't mind being automatically added as a reviewer to PRs about the most of the code base...

pygy added a commit to pygy/mithril.js that referenced this pull request Jul 31, 2017

pygy added a commit that referenced this pull request Jul 31, 2017

Merge pull request #1923 from pygy/fix-change-log
Move the #1921/#1922 line into the v1.1.4 change set
@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Jul 31, 2017

@pygy Just add yourself here to whatever directory suits your fancy. 😉

@isiahmeadows

This comment has been minimized.

Copy link
Collaborator

isiahmeadows commented Jul 31, 2017

You'll need to look here, though.

@tivac

This comment has been minimized.

Copy link
Member

tivac commented Jul 31, 2017

Yep! No reason to wait for me, just add yourself to whichever things you care about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment