Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ospec] pinpoint the o.only() call site #2157

Merged
merged 1 commit into from May 22, 2018

Conversation

pygy
Copy link
Member

@pygy pygy commented May 20, 2018

Description

This adds a cleaned up stack trace after the o.only() warning.

I'll update the change log once #2147 is merged

Motivation and Context

Makes it easier to find the place you added that .only() call.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

Copy link
Member

@barneycarroll barneycarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant — that trick will do nicely for identifying the origin of async timeouts too.

@pygy
Copy link
Member Author

pygy commented May 22, 2018

Great minds think alike, I got the same thought when I saw #2159

@pygy pygy force-pushed the ospec-better-only-2018-5 branch from 2748d98 to 9806020 Compare May 22, 2018 16:32
@pygy pygy merged commit 010d8da into MithrilJS:next May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants