Make m.request work with async/await correctly.
#2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`m.xhr` was a relic of the rewrite days prior to the release of v1.0.0, before it was renamed `m.request` to align with v0.2.x. This just strips some of that legacy naming.
It looked like a V8 bug, but read the two big code comments and follow their links. It's a bit more subtle than it looks, and V8's in the right here.
dead-claudia
force-pushed
the
fix-request
branch
from
485a483
to
00481de
Compare
|
Posted a long post-mortem/explainer, targeted towards the less technical, on Twitter, in case any of you all are curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A very small, subtle workaround with a lot of code explaining why it's necessary. The test was by far harder to get right than the fix itself, and it required a bit of spec reading and careful coding.
Motivation and Context
Fixes #2426
How Has This Been Tested?
Added a new test, after quite a bit of study on the subject matter. Conveniently, Node also uses V8, so I could easily verify the test there. It shouldn't affect others like Firefox, since they should be "working" already.
Types of changes
Checklist:
docs/change-log.md