String variables not correctly resolved

[sebastiansandqvist]

I have the following component which works without mopt enabled, but is broken with mopt:

const NEWEST = 'Newest first';
const VOTES = 'Most votes';
const SortToggle = {
    view({ attrs }) {
        return (
            m('.SortToggle',
                m('.SortToggle-option', { onclick() { attrs.sortBy(NEWEST); } }, NEWEST),
                m('.SortToggle-option', { onclick() { attrs.sortBy(MOST_VOTES); } }, MOST_VOTES)
            )
        );

    }
};

It works fine using mopt if I inline the string constants, like this:

const NEWEST = 'Newest first';
const VOTES = 'Most votes';
const SortToggle = {
    view({ attrs }) {
        return (
            m('.SortToggle',
                m('.SortToggle-option', { onclick() { attrs.sortBy(NEWEST); } }, 'Newest first'),
                m('.SortToggle-option', { onclick() { attrs.sortBy(MOST_VOTES); } }, 'Most votes')
            )
        );

    }
};

[tivac]

Thanks for the report!

Can you provide examples of the broken output on a minimal repro? That'd be a huge help for figuring out the issue here!

[sebastiansandqvist]

Sure, here you go: https://github.com/sebastiansandqvist/mopt-bug-repro

[sebastiansandqvist]

The issue appears to only happen if both of the following conditions are met:

• a variable is being used rather than a literal as the text node
• the component contains a second argument for attrs

[tivac]

mithril-objectify isn't compatible with the rewrite branch of mithril.

See MithrilJS/mithril.js#1086 for why. There is a rewrite branch where I was working on support but I've held off on further work because there still isn't a great way to support the underlying vnode structure from a static analysis tool.