-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file: protocol and better Windows shims, cleaning up cruft #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Windows to the testing matrix, to prevent this from happening in the future. https://docs.travis-ci.com/user/reference/windows
Once you do that (and assuming it passes there), it's got my stamp of approval.
Oh hai Claudia, I'll take a look hopefully this evening |
6f6099f
to
f0795cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the couple nits, please also rip out .travis.yml
(Edit: and remove/replace other Travis-related stuff as applicable like the badge in the README) if you're going to switch to GitHub Actions for testing.
I wasn't expecting the more invasive changes, but I'm okay with the rest modulo the above.
var shortDelay = 10 | ||
var middleDelay = 50 | ||
var longDelay = 200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Yes, I had read that the new owner was shady, and this confirmed my impression, hence the move to GH actions. I'll take your suggestions into account... This is in a WIP state obviously, I'm making progress in a dedicated branch over at https://github.com/pygy/ospec/tree/actions-tests to avoid spamming the gitter log. |
@pygy On that note, follow up across all our repos once you get this one in shape. |
@isiahmeadows We use the previous stable release to run the current test suite, but this won't work for CI on Windows (because the ESM tests won't work there with the stable version), so I propose we release, on a distinct NPM channel, one version that uses itself as a test harness, then release a stable release that relies on the aforementioned (and bump the devDep immediately after publishing so that future versions once again can rely on the previous stable release). Edit, actually, no need to do a custom release, I can have v4.1.2 depend on a git hash rather than the NPM package
Gotcha |
Alternative: I pull your patch and verify it locally. I can patch with a
quick hack easily enough - that's how I'm getting by with Mithril.
|
This is another take on #28, plus some cleanup.
We add the
file:
, a dev dependency oncli-shims
to get the exact samenode_modules/.bin
shims as NPM.I also removed the 'old style count' from the log, and the corresponding infrastructure.
I still have to fix the release instructions and the change log.
How Has This Been Tested?
I tried it the best I could from macOS (by using the shims there too, it runs the
bin/sh
one), but this needs to be tested in Windows before it is merged.Types of changes
Checklist: