fix: Always explicitly exit() to avoid hangs

[maranomynet]

Description

Fixes this problem:

import o from 'ospec';

o.spec('This dangling setInterval', () => {
  setInterval(() => undefined, 100);

  o('causes ospec to hang', () => {
    o(true).equals(true);
  });
});

Motivation and Context

Tests that import code from 3rd party libraries can cause ospec to unexpectedly hang, even though your own code and tests are perfectly fine.

How Has This Been Tested?

By pasting the above code into a file called hangtest.mjs and running ospec hangtest.mjs.

Without the fix the process doesn't exit.

With the fix it exits like normal.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation change

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read all applicable contributing documents.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the change log (if applicable).

BTW: I Can't get the package tests to pass locally (MacOS 12.5) — not even on the untouched main branch:

git clone git@github.com:MithrilJS/ospec.git
cd ospec
git checkout main  # Already on 'main'
yarn install
yarn run test
# 30 out of 4024 assertions failed
yarn run self-test
# 30 out of 4024 assertions failed

[maranomynet]

yarn patch ospec is currently saving my a**. 😅

[maranomynet]

Any comments @pygy ?

[pygy]

That sounds good, could you push a dummy commit to re-launch CI? The logs have expired, and I can't find how to relaunch these jobs (neither can I relaunch old Mithril jobs, so it could be an expiration thing here too).

[maranomynet]

Pushed a trivial fix to the README, for luck.

[pygy]

Merging, I'll publish a new version this evening and investigate where pnpm fails.

[pygy]

Many thanks for raising the issue and providing a patch.

[pygy]

@maranomynet @v4.1.7 is out

[maranomynet]

Thank you.