OAuth1 does not work for paginated request

[MitjaBezensek]

The pagination seems to break the OAuth1 authentication. The problem is that the url is just appened to the base url of the resource. For OAuth1 this is problematic since oauth_signature is calculated based on it.

The solution might be quite simple. We should pass a List of parameters to the ExecuteRequest method which will then just add them as parameters like so: request.AddParameter("pagelen", 30);

I have tested this and it works. @0x1mason are you up for this one since you might be the most familiar with the logic of pagingation?

[0x1mason]

I'll try to take a look at it next week.
On Oct 16, 2015 4:56 PM, "Mitja Bezenšek" notifications@github.com wrote:

The pagination that @0x1mason https://github.com/0x1mason added seems
to break the OAuth1 authentication. The problem is that the url is just
appened to the base url of the resource. For OAuth1 this is problematic
since oauth_signature is calculated based on it.

The solution might be quite simple. We should pass a List of parameters to
the ExecuteRequest method which will then just add them as parameters
like so: request.AddParameter("pagelen", 30);

I have tested this and it works. @0x1mason https://github.com/0x1mason
are you up for this one since you might be the most familiar with the logic
of pagingation?

—
Reply to this email directly or view it on GitHub
#23.

[MitjaBezensek]

Great 👍

[MitjaBezensek]

Did you maybe start on this? I'll have some time tomorrow and could take this on, but don't want to duplicate the effort :)

[0x1mason]

I'll have time next week. Sorry, been quite busy.
On Oct 31, 2015 3:27 AM, "Mitja Bezenšek" notifications@github.com wrote:

Did you maybe start on this? I'll have some time tomorrow and could take
this on, but don't want to duplicate the effort :)

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

[0x1mason]

However, if you think you can knock it out quickly, then by all means, go
ahead. I'm no longer working at the company that requires this library, so
I won't be contributing as much, unfortunately.
On Oct 31, 2015 3:27 AM, "Mitja Bezenšek" notifications@github.com wrote:

Did you maybe start on this? I'll have some time tomorrow and could take
this on, but don't want to duplicate the effort :)

—
Reply to this email directly or view it on GitHub
#23 (comment)
.

[MitjaBezensek]

Yeah, no problem. I have some spare time so I'll tackle it.