[desktop_webview_window] More control over webview position and size under windows #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iri-Hor
changed the title
Iri-Hor
changed the title
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses #205. It enables a plugin user to exactly specify the exact position and size of the webview window in pixels. Its also possible to open the webview window maximized.
Currently the new feature is only available for windows. This PR is a suggestion how such a new feature could look like. The current behaviour is to scale the given size to 96 dpi (no matter what the actual dpi of the monitor is) and open the webview window centered on the main screen. If the size ist too big, its just clipped and not centered correctly anymore. I dont understand the idea behind this