[desktop-webview-window] Control URL requests made by the webview (Breaking!) #296
Conversation
| {flutter::EncodableValue("url"), flutter::EncodableValue(wide_to_utf8(std::wstring(uri)))}, | ||
| })); | ||
|
|
||
| if (triggerOnUrlRequestedEvent) { |
There was a problem hiding this comment.
Is this necessary? It should make more sense to trigger onUrlRequest on any request (including from navigate(String) method).
There was a problem hiding this comment.
In my opinion its more convenient like this, because otherwise the call of "webview.launch(url)" would trigger the OnUrlRequest event every time and you manually had to grant it every time. If you call "webview.launch(url)" you know already that the webview will navigate to the url now, because you requested it yourself. But I am more interested in navigations triggered by the webview itself.
There was a problem hiding this comment.
But I can also make it, that also "webview.launch(url)" triggers the event. How would you like to have it?
There was a problem hiding this comment.
sorry for later.
But I still stand by my opinion.
for example:
If you need to display the currently requested URL in the console or elsewhere, you only need to add a callback instead of adding code in various places.
There was a problem hiding this comment.
Ok seems also reasonable. Then I suggest to add an optional parameter with default value to webview.launch:
webview.launch(..., triggerOnUrlRequestEvent=true)
There was a problem hiding this comment.
I added a new commit containing the additional parameter for webview.launch
Please review
| @@ -222,13 +224,13 @@ class WebviewImpl extends Webview { | |||
| } | |||
|
|
|||
| @override | |||
| void addOnUrlRequestCallback(OnUrlRequestCallback callback) { | |||
There was a problem hiding this comment.
the callbackparameter should be nullable
| } | ||
|
|
||
| @override | ||
| void removeOnUrlRequestCallback(OnUrlRequestCallback callback) { | ||
| _onUrlRequestCallbacks.remove(callback); | ||
| void removeOnUrlRequestCallback() { |
There was a problem hiding this comment.
we can remove this function.
|
LGTM, Thanks for the contribution. 💙 |
This PR introduces the capability of controlling url requests made by the webview. Therefore the "OnUrlRequestCallback" now allows to return a boolean value. Returning true grants the webview the navigation to the requested url and returning false doesn't.
Caution: Changes are breaking, because the function "addOnUrlRequestCallback" is now called "setOnUrlRequestCallback", because there is only one of those callbacks possible anymore, as multiple callbacks could return conflicting values for granting or rejecting the url request.