fix syntax error #120
Merged
fix syntax error #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which your dart version? |
|
3.0.5 |
boyan01
reviewed
Jan 6, 2024
lib/src/util/crypto_util.dart
Outdated
| @@ -82,7 +82,7 @@ UuidValue nameUuidFromBytes(List<int> name) { | |||
| final bytes = md5.convert(name).bytes; | |||
| bytes[6] = (bytes[6] & 0x0f) | 0x30; | |||
| bytes[8] = (bytes[8] & 0x3f) | 0x80; | |||
| return UuidValue.fromList(bytes); | |||
| return UuidValue.fromList(Uint8List.fromList(bytes)); | |||
There was a problem hiding this comment.
the bytes from md5.convert(name).bytes should be List<int>
and UuidValue.fromList(List<int> byteList, {int? offset}) also accept List<int> as a parameter.
There should be no syntax errors here.
There was a problem hiding this comment.
whoops. I put the fix on the wrong line. Updated it.
|
SGTM dart 3.1 has a break change for this dart-lang/sdk#52801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.