Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Home Assistant > 0.96 #13

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

xerxes87
Copy link

@xerxes87 xerxes87 commented Aug 9, 2019

Hi Mmodarre,

here the PR for the Home Assistant > 0.96 support, with fixed requirement.

Thanks for review!

BR philwilldo

@meichthys
Copy link

@xerxes87 Is this merge still valid? I tried your branch and i still seemed to run into the same error when validating the yaml:

image

@chiefcomm
Copy link

@Mmodarre the original developer hasn't been making updates since this integration broke back at version 0.95 - I suggest reading https://community.home-assistant.io/t/add-support-for-fujitsu-wireless-air-conditioning-control-app-fglair/65999/101 which explains the changes made by @xerxes87

@meichthys
Copy link

meichthys commented Dec 31, 2019

@Mmodarre hasn't made commits recently but he has had activity on issues as recent as July and has made contributions to the underlying pyfujitsu project as recent as November.

@pilot1981
Copy link

I already saw changes reported at https://community.home-assistant.io/t/add-support-for-fujitsu-wireless-air-conditioning-control-app-fglair/65999/103 but I don't understand what contain file token.txt...

@meichthys
Copy link

@pilot1981 I'm at the same point as you. I believe the token.txt file can be left empty. I think it populates automatically when connecting to the FGLair server.

Copy link

@meichthys meichthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Looks like that should fix:
image

@meichthys
Copy link

@Mmodarre Could we get this pull request approved? We have a little work to do to get things working for v0.113, but this would be a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants