Bugs in Sim.Thomas.Coords

[rueuntal]

Hi Felix - I'm using your Sim.Thomas.Coords function in our sensitivity test for mobr, but there seems to be two bugs under the scenario when sigma is large (ie. the Poisson case):

1. xmax and ymax are undefined, and
2. species names are defined differently. Here they are defined as numbers (e.g., from 1 to 100), while in the other scenario they are defined as "species" + numbers (e.g., species1, species2, etc.)

Thanks!

[FelixMay]

Hi Xiao, thanks for this hint. I will fix it soon. Is it very urgent and should be done today? Otherwise I will try to do it tomorrow afternoon.

[rueuntal]

These are necessary for the sensitivity analysis to run; but since we'd
need to merge the commits and get things set up on the cluster first, it's
not super urgent. Tomorrow would be great. Thanks!

On Wed, Sep 28, 2016 at 3:24 AM, Felix May notifications@github.com wrote:

Hi Xiao, thanks for this hint. I will fix it soon. Is it very urgent and
should be done today? Otherwise I will try to do it tomorrow afternoon.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGoPndB6Xx5IfJqrJPYkfVF-d_xgdvkks5quhZCgaJpZM4KIQBu
.

[FelixMay]

Hello @reuntal I tried to fix the bug. I hope it works now.

[rueuntal]

Hi Felix - it's working perfectly now. Thanks!

On Wed, Sep 28, 2016 at 11:29 AM, Felix May notifications@github.com
wrote:

Hello @reuntal I tried to fix the bug. I hope it works now.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGoPk3W4R81E7EUBpYA48-Khsyb-5seks5quofTgaJpZM4KIQBu
.