Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseAdapter as adapter for all ViewHolders #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

forceporquillo
Copy link

@forceporquillo forceporquillo commented Sep 20, 2020

  • Add string resource text formatting when setting textViews.
  • DiffUtilComparator when updating the old and new list (keep BaseAdapter as Singleton Instance)
  • Add binder implementations on each ViewHolder class

https://patch-diff.githubusercontent.com/raw/MoIbrahim15/GadsLeaderboard/pull/1.diff
https://patch-diff.githubusercontent.com/raw/MoIbrahim15/GadsLeaderboard/pull/1.patch

I also added DiffUtilComparator class whenever or in case you're updating the data or fetching from remote source to compute old and new list so RV wont reinstantiated the adapter itself. (**but u have to instantiate singleton instance outside of viewmodel method**).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant