Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove diagnostics from summary #113

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

MoLow
Copy link
Owner

@MoLow MoLow commented Feb 1, 2024

Fixes #109

@MoLow
Copy link
Owner Author

MoLow commented Feb 1, 2024

@mcollina This still keeps the diagnostic as a notice but removes it from the summary.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e63d34a) 99.47% compared to head (2907f53) 99.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files           7        7           
  Lines         569      571    +2     
=======================================
+ Hits          566      568    +2     
  Misses          3        3           
Flag Coverage Δ
v18 99.47% <100.00%> (+<0.01%) ⬆️
v20 99.47% <100.00%> (+<0.01%) ⬆️
v21 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoLow MoLow merged commit 1e95cf0 into main Feb 1, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
@MoLow MoLow deleted the better-diagnostic-detection branch February 1, 2024 12:53
@mcollina
Copy link

mcollina commented Feb 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github: diagnosticts appear inside the "test results summary"
2 participants