New SFX #41
Merged
New SFX #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mason Wendell <mason@zivtech.com>
| @@ -0,0 +1,19 @@ | |||
| <!doctype html> | |||
| <link rel="stylesheet" href="s.css" /> | |||
| <h1>Tests for <a href="../../">recipes</a>/<a href="../">effect</a>/scatter</h1> | |||
There was a problem hiding this comment.
There is a mistake in this breadcrumb
|
Well done ! |
|
Thanks for the notes. :) Scatter: I didn't need the wrapper so I removed it. Tucked / Taped corners: I reworked them into two mixins that share the same code. I also re-ordered the arguments since I think the color arg will be used more often. |
MoOx
added a commit
that referenced
this pull request
Feb 20, 2012
2 new effects (scatter & corner tucked/taped)
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was refactoring some effects in my other project and I think this is probably a better home for them. Let me know what you think. thanks