Update stylelint & stylelint-config-standard. (#718) #741
Conversation
|
@ben-eb we follow standard rule. LGTM |
|
The reference should be edited in all places:
|
| @@ -1,6 +1,6 @@ | |||
| .banner { | |||
| position: fixed; | |||
| position: sticky; | |||
| position: sticky; /* stylelint-disable-line */ | |||
There was a problem hiding this comment.
It's a duplicate declaration, Stylelint would prefer that either fixed or sticky was specified, not both.
There was a problem hiding this comment.
Hummmm ok... Not sure if that make total sense to get this in the "standard" config since this kind of tricks are handy when you work with CSS but I guess it's not a big deal for us... poke @davidtheclark @jeddy3
There was a problem hiding this comment.
I've stuck with the standard configuration instead of adapting the configuration to fit the CSS
馃槈
There was a problem hiding this comment.
Hello. I hadn't considered that use case when enabling the declaration-block-no-duplicate-properties rule. I had assumed all fallbacks would be handled by tooling.
There's an appropriate option that to make the rule more permissive for this situation: ignore: ["consecutive-duplicates-with-different-values"].
I've created an issue to discuss using that option by default in the standard config.
|
This should close #647 as well |
I've stuck with the standard configuration instead of adapting the configuration to fit the CSS, hope this is OK. 馃槃