Skip to content
This repository has been archived by the owner on Mar 18, 2019. It is now read-only.

Upgrade postcss-apply dependency #318

Closed
wants to merge 1 commit into from

Conversation

pascalduez
Copy link
Contributor

@MoOx
Copy link
Owner

MoOx commented Oct 4, 2016

Can I release this as a patch? Looks like it's a patch.

@pascalduez
Copy link
Contributor Author

Can I release this as a patch? Looks like it's a patch.

I would say so.
Except if people where relying on the erroneous previous behavior.

@MoOx
Copy link
Owner

MoOx commented Oct 11, 2016

Can you provide an example of the change? Like input before+output and input after+output?

@pascalduez
Copy link
Contributor Author

input

:root {
  --foobar: {
    color: red;
    content: 'foobar';
  };
}

.foo {
  @apply --foobar;
}

:root {
  --foobar: {
    color: blue;
  };
}

.bar {
  @apply --foobar;
}

Before

output

.foo {
  color: red;
  content: 'foobar';
}

.bar {
  color: blue;
}

After

output

.foo {
  color: blue;
}

.bar {
  color: blue;
}

@MoOx
Copy link
Owner

MoOx commented Oct 11, 2016

Ok thanks. This will cause trouble for sure. Will cut a major release for this.

@ritasilvasousa
Copy link

Would it be possible to update to v0.6 of postcss-apply instead of just v0.4?

- Implement proper property set overrides
- See pascalduez/postcss-apply#10
- Implement from js custom property sets declaration
- See pascalduez/postcss-apply#15
- Added a `preserve` option
- See pascalduez/postcss-apply#14
@pascalduez
Copy link
Contributor Author

Bumped the version, updated the commit message.
Please see the Changelog for differences.

There's still something I would like to work out and will then release a 1.0.0 though.

@Semigradsky Semigradsky added this to the v3.0.0 milestone May 7, 2017
@MoOx
Copy link
Owner

MoOx commented Jul 5, 2017

Closing in favor of #400

@MoOx MoOx closed this Jul 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants