Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MoarVM Fails to Compile on OpenSUSE due to missing libffi.so.6 #999

Open
samcv opened this issue Nov 25, 2018 · 4 comments
Open

MoarVM Fails to Compile on OpenSUSE due to missing libffi.so.6 #999

samcv opened this issue Nov 25, 2018 · 4 comments
Labels
build Issues related to building and compiling

Comments

@samcv
Copy link
Member

samcv commented Nov 25, 2018

OpenSUSE Tumbleweed has libffi.so.7 now, and not libffi.so.6. Compiling with no options or '--has-libffi' fails with:

preprocessing src/jit/x64/emit.dasc
3rdparty/dynasm/minilua: error while loading shared libraries: libffi.so.6: cannot open shared object file: No such file or directory
make: *** [Makefile:657: src/jit/x64/emit.c] Error 127
@samcv samcv added the BLOCKER Preventing the next release of MoarVM, or just needing attention before the release label Nov 25, 2018
@samcv
Copy link
Member Author

samcv commented Nov 25, 2018

It compiles fine if I clone MoarVM from scratch. So this makes this less severe. I would still like to get this fixed before release though.

samcv added a commit that referenced this issue Nov 25, 2018
@samcv
Always rebuild minilua to work around issue #999
9ef725d 
This ensures that minilua will always be rebuild. This fixes bug #999,
though we may find a better solution.

We declare ALWAYS_REBUILD as a target, and use the .PHONY property to
designate that it's not an actual file (though it's unlikely that file
would exist on the users computer). While we're there, also add all the
other phony rules like 'install' 'clean' 'lib' etc. as .PHONY so the
rules won't break if those files happen to exist in that folder.
samcv added a commit that referenced this issue Nov 25, 2018
@samcv
Ensure make realclean removes minilua binary
d590f25 
Looks like this was forgotten. Discovered due to issue #999.
@samcv
Copy link
Member Author

samcv commented Nov 27, 2018

This has been worked around for now. I am taking the blocker status off but leaving the bug open, since the current fix is not ideal. With the fix we rebuild minilua every time, but it prevents people upgrading to a newer release from having the build fail.

@samcv samcv added build Issues related to building and compiling and removed BLOCKER Preventing the next release of MoarVM, or just needing attention before the release labels Nov 27, 2018
@bdw
Copy link
Contributor

bdw commented Dec 9, 2018

Maybe it's simpler to make minilua be compiled statically and with somewhat fewer libraries.
I'll have a look at how luajit does it.

bdw added a commit that referenced this issue Dec 16, 2018
@bdw
[JIT] Compile minilua with only the needed flags
66efd5d 
Issue #999 seems to be avoidable mostly by restricting minilua to
compile with just the libraries that it needs, rather than all that
MoarVM brings in. Or thats' my theory at least.
Removes the always-recompile behaviour, which was annoying me.
bdw added a commit that referenced this issue Dec 19, 2018
@bdw
[JIT] Compile minilua with only the needed flags
732ca8c 
Issue #999 seems to be avoidable mostly by restricting minilua to
compile with just the libraries that it needs, rather than all that
MoarVM brings in. Or thats' my theory at least.
Removes the always-recompile behaviour, which was annoying me.
bdw added a commit that referenced this issue Dec 26, 2018
@bdw
[JIT] Compile minilua with only the needed flags
db9376d 
Issue #999 seems to be avoidable mostly by restricting minilua to
compile with just the libraries that it needs, rather than all that
MoarVM brings in. Or thats' my theory at least.
Removes the always-recompile behaviour, which was annoying me.
@bdw
Copy link
Contributor

bdw commented Dec 31, 2018

Apparently, but I have no way to check this, macOS doesn't have -lm..... so this needs some tweaking presumably.

bdw added a commit that referenced this issue Jan 6, 2019
@bdw
[JIT] Compile minilua with only the needed flags
5ae8072 
Issue #999 seems to be avoidable mostly by restricting minilua to
compile with just the libraries that it needs, rather than all that
MoarVM brings in. Or thats' my theory at least.
Removes the always-recompile behaviour, which was annoying me.
bdw added a commit that referenced this issue Jan 6, 2019
@bdw
[JIT] Compile minilua with only the needed flags
45cf901 
Issue #999 seems to be avoidable mostly by restricting minilua to
compile with just the libraries that it needs, rather than all that
MoarVM brings in. Or thats' my theory at least.
Removes the always-recompile behaviour, which was annoying me.
@dontlaugh dontlaugh mentioned this issue Mar 14, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues related to building and compiling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdw @samcv