fix rakudo/rakudo#2965 #1116
Merged
fix rakudo/rakudo#2965 #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this patch, the following throws 3 compile-time exceptions instead of segfaulting: I'm trying to figure out how to write a test that passes when it throws an exception at compile time |
|
|
kazcw
added a commit
to kazcw/rakudo
that referenced
this pull request
Jun 8, 2019
This will segfault until it's built on MoarVM/MoarVM#1116
kazcw
added a commit
to kazcw/rakudo
that referenced
this pull request
Jun 8, 2019
This will segfault until it's built on MoarVM/MoarVM#1116
|
Hm, this causes the new exception to be thrown upon attempts to HAS objects of types that aren't CArray/CUnion/CP*STruct. I should move the check into all the appropriate switch branches so it fails right for the never-HASable cases... |
You can't HAS a type before it's defined, whether it be stubbed or an attempt at recursive HASation. This changes the penalty from segfaulty death to merciful exception.
kazcw
force-pushed
the
cant-has-incomplete-type
branch
from
3645bc0
to
36469a6
Compare
|
Ok, I made the check more fine grained so the new error will never occur when a null-derived pointer dereference didn't before |
jnthn
approved these changes
Jun 9, 2019
kazcw
added a commit
to kazcw/rakudo
that referenced
this pull request
Jun 9, 2019
This will segfault until it's built on MoarVM/MoarVM#1116
ugexe
pushed a commit
to rakudo/rakudo
that referenced
this pull request
Jun 9, 2019
This will segfault until it's built on MoarVM/MoarVM#1116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception rather than segfault in response to an attempt to HAS a type before it's defined (rakudo/rakudo#2965)