Add missing concreteness checks to most array ops #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a ton of segfaults when type objects are passed to array ops, along with one case in particular where splicing a type object on index 0, inserting 0 elements from another type object would cause moar to attempt to allocate an 18 quintillion element array.
Kaiepi
force-pushed
the
array-op-concreteness
branch
from
e25c495
to
a5d553c
Compare
jnthn
approved these changes
Oct 14, 2019
|
Makes sense to me; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a ton of segfaults when type objects are passed to array ops,
along with one case in particular where splicing a type object on index
0, inserting 0 elements from another type object would cause moar to
attempt to allocate an 18 quintillion element array.