Implement NativeCall wide string support #1137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's ridiculous to try to work them out entirely via macros since they differ depending on platform, architecture, and compiler all at once, so use a compiler probe instead.
This uses no more memory than before on 64 bit systems and is required to implement wide string support.
Required before wide string support can be implemented.
It'd help if the code specific to Windows would actually get used.
Originally I was planning on passing the length of strings to the CStr REPR using it, but it's impossible to know before the type is composed.
Before, they were being cast to UTF-8 strings, which breaks wide/u16/u32 strings in the process.
"type" is used to pass type names, not constants representing types.
Kaiepi
force-pushed
the
nativecall-unicode
branch
from
63d2f38
to
e6b3af2
Compare
|
Looks like AppVeyor is unhappy with my use of Edit: I didn't need to lol |
Kaiepi
force-pushed
the
nativecall-unicode
branch
from
be39a08
to
07d63b1
Compare
Kaiepi
force-pushed
the
nativecall-unicode
branch
2 times, most recently
from
3869964
to
f39103b
Compare
Kaiepi
force-pushed
the
nativecall-unicode
branch
from
f39103b
to
fcfaa68
Compare
|
Is there a reason why this isn't merged yet? Do the core devs need a poke? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the Rakudo pullreq for info on what this does