Add GB18030 encode, decode, and decodestream support #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcv
requested changes
Aug 24, 2019
src/strings/gb18030.c
Outdated
| } | ||
|
|
||
| MVMint32 gb18030_valid_check_len4_first2(MVMint32 c_1, MVMint32 c_2) { | ||
| return (((0x81 <= c_1 && c_1 <= 0x83) || (c_1 == 0x84 && c_2 == 0x30)) && (0x30 <= c_2 && c_2 <= 0x39)) || (c_1 == 0x84 && c_2 == 0x31) ? 1 : 0; |
There was a problem hiding this comment.
Same here and all the other places
src/strings/gb18030.c
Outdated
|
|
||
| MVMint32 gb18030_valid_check_len4(MVMint32 c_1, MVMint32 c_2, MVMint32 c_3, MVMint32 c_4) { | ||
| if ((0x81 <= c_1 && c_1 <= 0x83) || (c_1 == 0x84 && c_2 == 0x30)) { | ||
| return (0x30 <= c_2 && c_2 <= 0x39) && (0x81 <= c_3 && c_3 <= 0xfe) && (0x30 <= c_4 && c_4 <= 0x39) ? 1 : 0; |
There was a problem hiding this comment.
The ? : ternary operator is not needed as (0x30 <= c_2 && c_2 <= 0x39) && (0x81 <= c_3 && c_3 <= 0xfe) && (0x30 <= c_4 && c_4 <= 0x39) will evaluate to if true to 1 or false as 0 without it.
src/strings/gb18030.c
Outdated
| } | ||
| else { | ||
| if (i + 1 < bytes) { | ||
| // GB18030 codepoint of length 2 |
There was a problem hiding this comment.
We prefer using /* comment */ style comments in MoarVM so if you can change all the // comments to use the /* */ style that would be great.
ZhongnianTao
commented
Aug 24, 2019
|
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds GB18030 encoding, the more recent extension to gb2312, to MoarVM.
It contains encode, decode, and decodestream support of GB18030.