Separate includes from submodules from system-wide includes #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently configuration variable cincludes contains `-I` flags for both includes from `3rdparty` for for those found with `pkg-config`. This is not correct as `cincludes` can be used by `NQP` and `Rakudo` for their C compilations. An example of a situation when this is necessary is rakudo/rakudo#3136 where `ffi.h` cannot be found even though `moar` is being compiled with it.
|
Makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently configuration variable cincludes contains
-Iflags for bothincludes from
3rdpartyfor for those found withpkg-config. This isnot correct as
cincludescan be used byNQPandRakudofor theirC compilations. An example of a situation when this is necessary is
rakudo/rakudo#3136 where
ffi.hcannot be found even thoughmoarisbeing compiled with it.