Use smaller buffer for native int to str coercion #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can only be up to 20 chars, and the actual worker functions only use 20 char arrays also.
|
I think there's an off-by-one here as the buffer gets ended with a null byte: |
That obviously pre-exists my change, but I'm seeing what happens if it's removed right now. |
|
NQP and Rakudo and all tests are ok with removing it. Should I add that to this PR or create a new one? |
|
Just add it please |
MoarVM doesn't use null-terminated strings, so this is unneeded.
MasterDuke17
force-pushed
the
use_smaller_buffer_for_native_int_to_str_coercion
branch
from
27ee006
to
bb27aeb
Compare
Done. |
MasterDuke17
deleted the
use_smaller_buffer_for_native_int_to_str_coercion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can only be up to 20 chars, and the actual worker functions only
use 20 char arrays also.
NQP builds ok and passes
make m-testand Rakudo builds ok and passesmake m-test m-spectest.