Maybe fix MVM_panic from entering GC during spesh #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MVM_gc_mark_thread_(un)blocked(tc)` calls were incorrect and caused `MoarVM panic: Must not GC when in the specializer/JIT` at random times. However, just removing them changed to causing `MoarVM panic: Invalid owner in item added to GC worklist`. Setting `MVM_GC_DEBUG` to `3` would reliably trigger the panic when building NQP. Removing overwriting the spesh facts fixed this, but I'm not 100% that the rest of the code is 100% correct.
timo
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
i believe the sym_facts->value.i part was wrong because facts are set on registers, not on literals, so no clue what exactly would happen here. perhaps another part of the code would read the pointer in .i as value.s and try to interpret the MVMHashEntry as an MVMString?
either way, this patch looks correct
Because `ins->info` is what's used to determine how many operands to access, we don't need to reallocate new operands in the gethllsym case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MVM_gc_mark_thread_(un)blocked(tc)calls were incorrect and causedMoarVM panic: Must not GC when in the specializer/JITat random times.However, just removing them changed to causing
MoarVM panic: Invalid owner in item added to GC worklist. SettingMVM_GC_DEBUGto3wouldreliably trigger the panic when building NQP. Removing overwriting the
spesh facts fixed this, but I'm not 100% that the rest of the code is
100% correct.
NQP builds correctly and passes
make m-testand Rakudo builds correcty and passesmake m-test m-spectest.