Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVM_malloc_trim would be better after MVM_gc_collect_free_gen2_unmarked #1335

Merged

Conversation

nwc10
Copy link
Contributor

@nwc10 nwc10 commented Aug 10, 2020

MVM_gc_collect_free_gen2_unmarked can free memory (particularly "overflow"
allocations for large objects), so the greatest chance of free memory at
the top of the address space will be here.

MVM_gc_collect_free_gen2_unmarked can free memory (particularly "overflow"
allocations for large objects), so the greatest chance of free memory at
the top of the address space will be here.
Copy link
Contributor

@niner niner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find!

Copy link
Member

@jnthn jnthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Good catch.

@jnthn jnthn merged commit 03d3e43 into master Aug 10, 2020
@jnthn jnthn deleted the MVM_malloc_trim-after-MVM_gc_collect_free_gen2_unmarked branch August 10, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants