Fix two *printf size warnings reported on ILP32 platforms. #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In debugserver.c, handle_id is 64 bit, so use PRId64. In the profiler, we print out the difference between two pointers. This has the type ptrdiff_t. It seems that on most platforms that ptrdiff_t is a typedef for long. However, on (at least) arm32 and sparc32 it is a typedef for int (despite int and long being the same size on these platforms). Hence *printf format checking warns about a mismatch between types. Oh so helpful. C11 provides a size modifier `t` for ptrdiff_t, but we're still stuck in the century of the fruitbat, so we can't use that. So just cast to long.
niner
approved these changes
Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debugserver.c, handle_id is 64 bit, so use PRId64.
In the profiler, we print out the difference between two pointers. This has
the type ptrdiff_t. It seems that on most platforms that ptrdiff_t is a
typedef for long. However, on (at least) arm32 and sparc32 it is a typedef
for int (despite int and long being the same size on these platforms).
Hence *printf format checking warns about a mismatch between types.
Oh so helpful.
C11 provides a size modifier
tfor ptrdiff_t, but we're still stuck inthe century of the fruitbat, so we can't use that. So just cast to long.