Fix possible GC upset caused by half-deserialized STables #1436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While deserializing STables, we may have to deserialize several objects. Doing
so can trigger a garbage collection run. At this point the STable will not be
fully set up yet. E.g. its type_check_cache_length was set but not actually
filled with appropriate objects. This could lead to the GC following invalid
pointers.
Fix by being more careful about setting up data structures hanging off STables
first and only attaching them to the STable once they are fully ready.