Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates and tweaks to Azure CI pipelines #1475

Merged

Conversation

MasterDuke17
Copy link
Contributor

The main pipelines now use Ubuntu 20.04 (the latest available) and I added
single 18.04 and 16.04 pipelines for GCC and Clang (so four new in total)
so we still get some minimal testing on older versions.

The main pipelines now use Ubuntu 20.04 (the latest available) and I added
single 18.04 and 16.04 pipelines for GCC and Clang (so four new in total)
so we still get some minimal testing on older versions.
Copy link
Member

@patrickbkr patrickbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

The standard Azure VMs have two vCPUs, so hopefully this will speed up
the pipelines a little.
@MasterDuke17 MasterDuke17 changed the title Update Azure CI linux versions + add old versions Some updates and tweaks to Azure CI pipelines Apr 20, 2021
@MasterDuke17 MasterDuke17 force-pushed the update_azure_pipeline_os_versions branch 6 times, most recently from 4f7f80b to e628a1f Compare April 21, 2021 15:22
Copy link
Member

@patrickbkr patrickbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we decide to just accept the occasional test failures on Windows caused by the -j2 for now? (This is not meant as a suggestive question. I really am unsure if I've maybe missed a bit of discussion about this.)

azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@MasterDuke17
Copy link
Contributor Author

Did we decide to just accept the occasional test failures on Windows caused by the -j2 for now? (This is not meant as a suggestive question. I really am unsure if I've maybe missed a bit of discussion about this.)

I don't think there was any definite yeas or nays. @ugexe said he prefers to only use a single job in his CI pipelines for reproducibility, but I don't believe he actually voted against this. I prefer using multiple jobs as that is more likely to uncover potential problems, even though it may make reproducing them harder. Since there are a couple approves for this PR I'll leave it as is (adding the -j2), but if there's a subsequent consensus against that's fine, we can revert.

In the multiple runs since that first one, I haven't seen that problem re-appear.

Only for Linux (and not when MoarVM is compiled with coverage support,
I'm not sure if that would cause a problem for `--full-cleanup`).
@MasterDuke17 MasterDuke17 force-pushed the update_azure_pipeline_os_versions branch from e628a1f to e3decf0 Compare April 22, 2021 08:44
@patrickbkr
Copy link
Member

Looking good. 👍🏽

@MasterDuke17 MasterDuke17 merged commit adc1dc6 into MoarVM:master Apr 22, 2021
@MasterDuke17 MasterDuke17 deleted the update_azure_pipeline_os_versions branch April 22, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants