Convert the use of a Variable Length Array to a regular allocation #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLA fails on windows, this allows us to catch it on other platforms first. Resolves #1537
Instead of allocating each time through the loop, keep a small array to reuse each time through the loop. Expand the size of the array when necessary.
The Fixed Size Allocator should be slightly faster than malloc for the small allocations we need, and possibly much faster than free, because we know the size of the memory we are deallocating.
|
@jnthn are my assumptions about the FSA being a better fit reasonable? I haven't actually benchmarked them :-) |
|
@coke I thought it clearer (for history) to merge my changes to your original commit into one change. It's not clearer for attribution - this is still fine with you? |
|
|
|
@nwc10 - sure. The config change was ok, but my code change was a WIP that needed fixing anyway, thanks! |
|
celo_duro suggested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should restore the build on MSVC.