Correctly clean up disp programs in cleanup_entry #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroying the dispatch programs in inline cache entries when destroying static frames was introduced in 6b50be1, but there was a typo in the case of polymorphic entries.
jnthn
approved these changes
Sep 20, 2021
MasterDuke17
deleted the
fix_disp_programs_not_getting_cleaned_from_polymorphic_inline_cache_entries_on_new-disp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destroying the dispatch programs in inline cache entries when destroying
static frames was introduced in 6b50be1,
but there was a typo in the case of polymorphic entries.
valgrind --leak-check=full ./install/bin/raku --full-cleanup -e ''now just reportsdefinitely lost: 2,024 bytes in 1 blocks.