Fixing warnings seen when compiling with GCC using -O2 (instead of the -O3 that the build defaults to) #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise GCC at the -O2 optimization level warns that `size` may be used uninitialized.
niner
approved these changes
Oct 19, 2021
by twice moving a conditional in MVM_string_index outside a loop, so it won't potentially be used uninitialized. I think it couldn't actually happen, but this is probably a little faster also.
MasterDuke17
force-pushed
the
fix_warnings_found_by_gcc_at_O2_optimization_level
branch
from
4b6fe68
to
4293ea8
Compare
MasterDuke17
deleted the
fix_warnings_found_by_gcc_at_O2_optimization_level
branch
|
Looks good. Thanks @MasterDuke17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NQP builds ok and passes
make m-testand Rakudo builds ok and passesmake m-test m-spectest(with both GCC and Clang, and -O2 and -O3).