Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround tommath issue #56, affects random bigint numbers > 32bits #357

Merged
merged 2 commits into from Oct 16, 2016
Merged

Workaround tommath issue #56, affects random bigint numbers > 32bits #357

merged 2 commits into from Oct 16, 2016

Conversation

skids
Copy link
Contributor

@skids skids commented Apr 8, 2016

See rakudo RT#109586

@skids
Copy link
Contributor Author

skids commented Apr 8, 2016

Totally untested (up way past bedtime) and needs review.

@skids
Copy link
Contributor Author

skids commented Apr 8, 2016

Managed to squeeze off a rakudo and nqp test run before bed; they were OK. Only tested on 64-bit linux. Needs testing on 32-bit.

@jnthn
Copy link
Member

jnthn commented Apr 8, 2016

I don't have a 32-bit thingy handy to try it out on, but I'm happy enough with the patch otherwise.

@jnthn
Copy link
Member

jnthn commented Apr 21, 2016

Any reports from 32-bit on this?

@FROGGS
Copy link
Member

FROGGS commented Oct 16, 2016

The tests pass before and after applying the changes on x86.

@FROGGS FROGGS merged commit 3f1ef57 into MoarVM:master Oct 16, 2016
@p6rt p6rt mentioned this pull request Jan 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skids @jnthn @FROGGS