Have two part loop in collapse strands to make loop tighter when possible #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible If we find out that we can't fit a string into 8 bits, we don't need to check anymore whether or not subsequent characters are > 127 or < -127. cygx++ for the suggestion Also eliminates the can_use_8bit variable
samcv
referenced
this pull request
Apr 7, 2017
This loop gets ran a huge number of times under collapsing strands workloads. If we're already set can_use_8bit, don't bother checking if the following graphemes are < -127 and > 127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we find out that we can't fit a string into 8 bits, we don't need to check
anymore whether or not subsequent characters are > 127 or < -127.
cygx++ for the suggestion
Also eliminates the can_use_8bit variable