Add MVMROOT around more reentrantmutex acquires #741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "Unknown lexical type encountered while building context iterator" error when MVM_iter() tries to handle unsigned integers.
The mutex acquire may GC block and thus trigger GC, moving objects.
The mutex acquire may GC block and thus trigger GC, moving objects.
Strings are unboxed and the resulting pointers stored in the scratch space on the stack so both the actual C call and the MVM_free call afterwards can access them. The scratch space is 0x40=64 bytes large and we already need 8 bytes for the native function's return value, leaving us with space for 7 string pointers.
Passing a pointer to an integer instead of the integer itself to the native function is easy. Getting the changed value back to the HLL code is the hard part. Since the native function writes to the register that's passed in the args buffer, the HLL code needs to read the value back from the args buffer. That's what the new getarg_* ops are for.
Spesh currently does not retain all facts when inlining calls. This then blocks JIT compilation of native sub bodies. Benchmarks show that JIT compilation is more important for performance than inlining of native subs, so mark the nativeinvoke* ops :noinline until spesh's restriction is lifted.
|
Will reopen in new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: 9ad1f5f