ucd2c.pl: Fix White_Space/space Unicode Property +many other improvements

[samcv]

• Fix Property Name 'space' so it doesn't incorrectly refer to the
  Line_Break=space property and fix White_Space property so it doesn't refer to
  Bidi_Class=White_Space and instead refers to the White_Space property.
  • Fixes "\t" ~~ /<:space>/ which now correctly matches
  • Fixes "1".uniprop('White_Space') so it doesn't return True
• Fix property names/values so that more variations of case and underline's
  are used. Before if we had a property name called Foo_Bar we would get:
  • FooBar (No underscore)
  • foobar (lowercase and no underscore)
    Now an additional one is added:
  • foo_bar (lowercase but with underscore retained)
• Add all property names first, before adding any property aliases. Also check
  that a property value does not have the same name as a property before
  putting it in the datastructure
• Remove workaround for correcting union property values which is no longer
  needed anymore since commit
• Rename some variables names to be more clear
• Fix sprintf warning by not escaping % signs as %%
• Add many more comments to this sub (emit_unicode_property_keypairs) than before

[zoffixznet]

That's a long list of changes. Perhaps, it's safer to merge it after the release? The whitespace thing was broken for some months; doesn't seem like it'd hurt to wait one more for its fix.

[lizmat]

+1 on post release

…

On 23 Jan 2018, at 18:58, Zoffix Znet ***@***.***> wrote: That's a long list of changes. Perhaps, it's safer to merge it after the release? The whitespace thing was broken for some months; doesn't seem like it'd hurt to wait one more for its fix. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[AlexDaniel]

I'm OK with this merged before the release as long as @samcv is confident with the changes. For rakudo star users that's not just one month to wait. If that's merged I'll do a quick toaster run to make sure the world didn't break apart.

[lizmat]

ok, if you’re willing to do that, I’m reverting to +1 *before* release :-)

…

On 23 Jan 2018, at 20:19, Aleks-Daniel Jakimenko-Aleksejev ***@***.***> wrote: I'm OK with this merged before the release as long as @samcv is confident with the changes. For rakudo star users that's not just one month to wait. If that's merged I'll do a quick toaster run to make sure the world didn't break apart. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[samcv]

@AlexDaniel yes i'm pretty confident in the changes :) pretty sure all will be fine on Toaster, but running it is a very good idea.