Expose file descriptors of IO::Socket::INET instances #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnthn
requested changes
Jun 22, 2018
| @@ -434,19 +434,32 @@ MVMint64 socket_getport(MVMThreadContext *tc, MVMOSHandle *h) { | |||
| return port; | |||
| } | |||
|
|
|||
| static MVMint64 socket_is_tty(MVMThreadContext *tc, MVMOSHandle *h) { | |||
| MVMIOSyncSocketData *data = (MVMIOSyncSocketData *)h->body.data; | |||
| return isatty(data->handle); | |||
There was a problem hiding this comment.
Would a socket ever be a TTY? I think this will break the Windows build; it'll need something like this doing.
There was a problem hiding this comment.
I'm not sure if it's actually possible or not, but I added it just to be safe
Before, `.native-descriptor` was available from IO::Socket, but always returned -1.
jnthn
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
.native-descriptorwas available from IO::Socket, but alwaysreturned -1.
Could be useful if people want to do stuff with sockets natively