JIT decoder(empty|takebytes) #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not sure if the impact can be this big, but i'd assume that ensure_decoder would be inlined in the non-jit version, and is a "full" call in this one. |
|
@timo huh, might that be the same for the other decoder* ops also? They could actually be faster non-jitted? Is there a way to fix that? |
|
either make a c function that's only meant to be called by the jit that has the |
bdw
reviewed
Aug 5, 2018
src/jit/graph.c
Outdated
| MVMint16 inc = ins->operands[3].reg.orig; | ||
| MVMJitCallArg argc[] = { { MVM_JIT_INTERP_VAR, { MVM_JIT_INTERP_TC } }, | ||
| { MVM_JIT_REG_VAL, { decoder } }, | ||
| { MVM_JIT_LITERAL_PTR, { (MVMint64)"decodertakebytes" } } }; |
There was a problem hiding this comment.
pls make this uintptr_t, we have enough unportable stuff going on
There was a problem hiding this comment.
I just copied this from the other decoder* cases. Should I change them all?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NQP builds ok and passes
make m-testand Rakudo builds ok and passesmake m-test m-spectest.This gets rid of some BAILs I saw when using Compress::Zlib. However, it seemed to actually make it slightly slower (roughly from 6.4s before to 6.6s after when
gzslurping a 975k file). @bdw any idea why?