[JIT] Use reference counting for maintaining multiple code copies #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We take some care to make executable memory read/executable, so they are mmap()'d. The copied' frames would have malloc()'d memory. It is probably better to treat them as shared resources and use reference counting to decide when to actually destroy them.
jnthn
approved these changes
Aug 19, 2018
|
Looks sane to me, though @niner can probably do a better review, having been in that bit of the code recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We take some care to make executable memory read/executable, so they are
mmap()'d. The copied' frames would have malloc()'d memory. It is
probably better to treat them as shared resources and use reference
counting to decide when to actually destroy them.
This may be the fix to some bugs, and it may not (JIT code copy and destruction both ought to be rare).