Add decodelocaltime op #947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdw
reviewed
Sep 10, 2018
src/platform/win32/time.c
Outdated
|
|
||
| void MVM_platform_decodelocaltime(MVMint64 time, MVMint64 decoded[]) { | ||
| const time_t t = (time_t)time; | ||
| struct tm *tm = localtime(&t, &tm); |
There was a problem hiding this comment.
I'd prefer the use of locatime_s here, which is equivalent to localtime_r in the POSIX world
There was a problem hiding this comment.
How portable across windows versions is localtime_s? I'm not a windows dev so I have no idea
There was a problem hiding this comment.
From my (limited) understanding, exactly as portable as localtime because it is part of the 'Universal C Runtime Library'.
|
I fixed the localtime_s use. I don't use windows so I haven't tested the fix :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help us remove nqp::p6decodelocaltime.
Not tested on windows as I don't have a dev env set up on it :(